Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban org.javassist:javassist #26071

Closed
ppalaga opened this issue Jun 12, 2022 · 9 comments · Fixed by #26069
Closed

Ban org.javassist:javassist #26071

ppalaga opened this issue Jun 12, 2022 · 9 comments · Fixed by #26069
Labels
area/dependencies Pull requests that update a dependency file kind/bug Something isn't working
Milestone

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Jun 12, 2022

Describe the bug

Similar case as #26066

quarkus-scheduler depends on org.javassist:javassist but we do not manage it and so other platform participants may bring an incompatible version.

Hence we should start managing org.javassist:javassist.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@ppalaga ppalaga added the kind/bug Something isn't working label Jun 12, 2022
@gsmet
Copy link
Member

gsmet commented Jun 12, 2022

@ppalaga do you know what's bringing Javassist? Ideally we should get rid of it.

@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 12, 2022

do you know what's bringing Javassist?

quarkus-scheduler via com.cronutils:cron-utils (not sure this is the only path)

Ideally we should get rid of it.

Why?

@gastaldi
Copy link
Contributor

do you know what's bringing Javassist?

quarkus-scheduler via com.cronutils:cron-utils (not sure this is the only path)

FTR I opened jmrozanec/cron-utils#521 removing it as it doesn't seem to be used in the codebase

@gastaldi gastaldi added area/dependencies Pull requests that update a dependency file and removed triage/needs-triage labels Jun 13, 2022
@gsmet
Copy link
Member

gsmet commented Jun 13, 2022

@ppalaga we try to favor ByteBuddy if possible. Obviously if a dependency needs it, we have to comply, but it's worth having a look at what brings it.

ppalaga added a commit to ppalaga/quarkus that referenced this issue Jun 13, 2022
@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 13, 2022

Should I remove the javassist commit from #26069 ?

@gsmet
Copy link
Member

gsmet commented Jun 13, 2022

If it's indeed not used by cron-utils, I would rather exclude it from there while waiting for @gastaldi 's PR to get in.

@ppalaga ppalaga changed the title Manage org.javassist:javassist Ban org.javassist:javassist Jun 13, 2022
@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 13, 2022

Ok, let me do it in #26069

ppalaga added a commit to ppalaga/quarkus that referenced this issue Jun 13, 2022
@ppalaga
Copy link
Contributor Author

ppalaga commented Jun 13, 2022

javassist now banned in #26069

ppalaga added a commit to ppalaga/quarkus that referenced this issue Jun 21, 2022
@quarkus-bot quarkus-bot bot added this to the 2.11 - main milestone Jun 23, 2022
@gsmet gsmet modified the milestones: 2.11 - main, 2.10.1.Final Jun 28, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jun 28, 2022
@gastaldi
Copy link
Contributor

If it's indeed not used by cron-utils, I would rather exclude it from there while waiting for @gastaldi 's PR to get in.

FWIW cron-utils 9.1.7 is now out without the dependency on Javassist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants