New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarkus image build fails when using fake registry name with quarkus.kubernetes.deploy=true #26385
Comments
/assign @iocanel |
For minikube, we pretty much already handle this case: https://quarkus.io/guides/deploying-to-kubernetes#deploying-to-minikube Essentially for Minikube we don't push to a registry but instead but to the docker daemon. How is this case different? |
That's the point, the registry a.b.c and image I tag it shouldn't be verified at build time, which in this case, is happening. |
Can you try adding The way things stand now, when you specify a registry, Quarkus will try to push the container image. |
Hi @geoand sry for the delay, I got the same behavior. |
Before this change, we handled Minikube in a special way in order to take advantage of the fact that the Minikube docker daemon already contained the built container image. This change introduces a way for users to opt in to this same feature by setting quarkus.kubernetes.prevent-container-image-push Resolves: quarkusio#26385
I have opened #26460. Can you check it out? |
This should be working as expcted, as I recently fixed some bugs around it. If not, then @spolti is either using a version prior to the fix or we have a regression. |
This change makes sure that quarkus.container-image.push=false is taken into account and always prevents container images from being pushed, even if a kubernetes extension requests a deployment. Resolves: quarkusio#26385
Make quarkus.container-image.push=false effective in all k8s extensions
This change makes sure that quarkus.container-image.push=false is taken into account and always prevents container images from being pushed, even if a kubernetes extension requests a deployment. Resolves: quarkusio#26385 (cherry picked from commit 7612dde)
Yay! |
Excellent! |
Describe the bug
When trying to building a application tagging for a non existing registry or using a image name that was not pushed yet, Quarkus Jib build will fail.
Use case: using minikube remote docker daemon to be able to build and deploy on Minikube without the need to push the container to a registry.
The issue below only happens in case you tag the image and set the kubernetes deployment to true together.
If only the Container image is done, it will work.
Expected behavior
Build is finished with no errors.
Actual behavior
Jib tries do validate the registry or query the image metadata leading the image build to fail.
How to Reproduce?
1- enable minikube remote docker daemon
2- build the application with the following properties:
Output of
uname -a
orver
Linux 5.18.5-200.fc36.x86_64 #1 SMP PREEMPT_DYNAMIC Thu Jun 16 14:51:11 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Output of
java -version
openjdk version "17.0.3" 2022-04-19 OpenJDK Runtime Environment 21.9 (build 17.0.3+7) OpenJDK 64-Bit Server VM 21.9 (build 17.0.3+7, mixed mode, sharing)
GraalVM version (if different from Java)
version from Quarkus native builder image
Quarkus version or git rev
2.10.0.Final
Build tool (ie. output of
mvnw --version
orgradlew --version
)Apache Maven 3.8.2 (ea98e05a04480131370aa0c110b8c54cf726c06f)
Additional information
No response
The text was updated successfully, but these errors were encountered: