Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report actionable error when extension @Recorder is in the wrong module. #27550

Closed
kdubb opened this issue Aug 27, 2022 · 2 comments · Fixed by #27558
Closed

Report actionable error when extension @Recorder is in the wrong module. #27550

kdubb opened this issue Aug 27, 2022 · 2 comments · Fixed by #27558
Assignees
@geoand
Labels
area/core kind/enhancement New feature or request
Milestone
2.13.0.CR1

Comments

@kdubb
Copy link
Contributor

kdubb commented Aug 27, 2022

Description

When building an extension that uses a Recorder for runtime initialization and that recorder is in the deployment module it reports LinkageErrors with no context to help fix the issue.

Apparently this is an incorrect configuration. The build should check and report this with a build error that lets the user know how to fix it.

Suggested error:

Runtime recorders must be in an extension's runtime module, `MyExtensionRecorder` is located in the deployment module.

Implementation ideas

No response
@kdubb kdubb added the kind/enhancement New feature or request label Aug 27, 2022
@kdubb kdubb changed the title Report actionable error when extension Recorder is in the wrong module. Report actionable error when extension @Recorder is in the wrong module. Aug 27, 2022
@kdubb
Copy link
Contributor Author

kdubb commented Aug 28, 2022

You can see the error(s) on this branch. Run maven install in the OpenFGA client extension.

@geoand geoand self-assigned this Aug 29, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Aug 29, 2022

/cc @Sanne, @aloubyansky, @gsmet, @radcortez, @stuartwdouglas

geoand added a commit to geoand/quarkus that referenced this issue Aug 29, 2022
@geoand
Fail extension build when @recorder is used in a deployment module
38fe23e 
Resolves: quarkusio#27550
@geoand geoand mentioned this issue Aug 29, 2022
Merged
geoand added a commit that referenced this issue Aug 29, 2022
@geoand
Merge pull request #27558 from geoand/#27550
e9194c7 
Fail extension build when @recorder is used in a deployment module
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Aug 29, 2022
fercomunello pushed a commit to fercomunello/quarkus that referenced this issue Aug 31, 2022
@geoand @fercomunello
Fail extension build when @recorder is used in a deployment module
2d45cab 
Resolves: quarkusio#27550
evanchooly pushed a commit to nenros/quarkus that referenced this issue Sep 8, 2022
@geoand @evanchooly
Fail extension build when @recorder is used in a deployment module
9619c7d 
Resolves: quarkusio#27550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoand geoand

Labels
area/core kind/enhancement New feature or request
Projects
None yet
Milestone
2.13.0.CR1
Development

Successfully merging a pull request may close this issue.

Fail extension build when @Recorder is used in a deployment module geoand/quarkus
2 participants
@kdubb @geoand