-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI failure on context propagation tests #2808
Comments
@FroMage can you take a look at this one? It seems to be a transient failure but maybe there's a bug hidden. |
I bet there is a bug hidden, there must be. But how often can you reproduce it? |
Dunno. So far, I had one failure on a Windows build on one PR. So that doesn't qualify as often and easily reproducible unfortunately :/. Just wanted to log the error properly. |
The code in question is:
Perhaps @stuartwdouglas would know if there's any way we can have |
Running techempower I see A LOT of those:
|
It would be a race. You must have already started another thread which is closing the async context. If you use io.undertow.servlet.spec.AsyncContextImpl#start to start the thread it will avoid this race as the task will not be run until the container has returned. |
Well, I don't think we can control how the async user threads are started (if any: sometimes they're just completed on some event loop). |
Fixes #2808, use the getAsyncContextInternal method
We just had a CI failure on a Windows build in the context propagation tests:
I haven't looked at the test but I think this part might be of interest:
Full log of the failing test:
The text was updated successfully, but these errors were encountered: