Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose information to extensions whether a build targets containers #2827

Closed
gunnarmorling opened this issue Jun 13, 2019 · 3 comments
Closed
Labels
kind/enhancement New feature or request triage/out-of-date This issue/PR is no longer valid or relevant

Comments

@gunnarmorling
Copy link
Contributor

See the discussion in #2794, there should be a way extensions can easily find out whether a build is targeting containers without having to query the native-image.container-runtime and native-image.docker-build system properties themselves.

@gunnarmorling gunnarmorling added the kind/enhancement New feature or request label Jun 13, 2019
@gsmet gsmet changed the title Expose information to extensions whether a build targest containers Expose information to extensions whether a build targets containers Nov 13, 2019
@gsmet
Copy link
Member

gsmet commented Nov 13, 2019

I'm not entirely sure if we have a way to do that now with the new stuff @stuartwdouglas worked on for the native image build.

@stuartwdouglas do you know off the top of your head if there is a way to do that now?

@stuartwdouglas
Copy link
Member

You can inject io.quarkus.deployment.pkg.NativeConfig and look at the containerBuild field

@stuartwdouglas
Copy link
Member

#5459 shows how this can be done

@gsmet gsmet added the triage/out-of-date This issue/PR is no longer valid or relevant label Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request triage/out-of-date This issue/PR is no longer valid or relevant
Projects
None yet
Development

No branches or pull requests

3 participants