Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes resources generation log not on par with what is generated #29209

Closed
loicmathieu opened this issue Nov 11, 2022 · 4 comments · Fixed by #30303
Closed

Kubernetes resources generation log not on par with what is generated #29209

loicmathieu opened this issue Nov 11, 2022 · 4 comments · Fixed by #30303
Labels
area/kubernetes kind/bug Something isn't working
Milestone

Comments

@loicmathieu
Copy link
Contributor

Describe the bug

When you generate a container image and Kubernetes resources but not push the image to a remote Docker registry, the following logs is shown

[WARNING] [io.quarkus.kubernetes.deployment.KubernetesDeployer] A Kubernetes deployment was requested, but the container image to be built will not be pushed to any registry because "quarkus.container-image.registry" has not been set. The Kubernetes deployment will only work properly if the cluster is using the local Docker daemon. For that reason 'ImagePullPolicy' is being force-set to 'IfNotPresent'.

However, the generated resouce have imagePullPolicy: Always.

Expected behavior

Either the log is updated either the generated resource is updated to match each other.

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

Ubuntu 22.04

Output of java -version

17

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.14.0.Final

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@loicmathieu loicmathieu added the kind/bug Something isn't working label Nov 11, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 11, 2022

/cc @Sgitario, @geoand, @iocanel

@geoand
Copy link
Contributor

geoand commented Jan 11, 2023

I remember we used to change the image pull policy but I don't see where we do that anymore...
I am thinking of removing the warning completely, WDYT @Sgitario ?

@Sgitario
Copy link
Contributor

I agree with you. The warning message is confusing more than helping. Will create a pull request to remove the warning.

@llowinge
Copy link
Contributor

@Sgitario @geoand Actually i've found such warning very handy - if it would actually works like written in the description. With local kubernetes developing, one really has to change the imagePullPolicy from Always to Never or IfNotPresent otherwise, the deployment will fail (because it tries to pull the image from dockerhub even it is already present locally).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants