Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for HTTP operation retries (with exponential backoff) in Kubernetes Client #29467

Closed
ManasMaji opened this issue Nov 24, 2022 · 4 comments · Fixed by #29470
Closed

Add support for HTTP operation retries (with exponential backoff) in Kubernetes Client #29467

ManasMaji opened this issue Nov 24, 2022 · 4 comments · Fixed by #29470
Labels
area/kubernetes kind/enhancement New feature or request
Milestone
2.15.0.CR1

Comments

@ManasMaji
Copy link

Description

Fabric8's Kubernetes client has exposed HTTP operation retry configuration options with exponential backoff since version 5.5.0 [0]:

  • kubernetes.request.retry.backoffLimit
  • kubernetes.request.retry.backoffInterval

Request Quarkus to add similar configurations in KubernetesClientBuildConfig to support retries when the HTTP status code is 500 (Status Internal Server Error), 503 (Status Service Unavailable), or 504 (Status Server Timeout).

[0] https://developers.redhat.com/articles/2021/07/16/whats-new-fabric8-kubernetes-client-version-550

Implementation ideas

No response
@ManasMaji ManasMaji added the kind/enhancement New feature or request label Nov 24, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Nov 24, 2022

/cc @Sgitario, @geoand, @iocanel

geoand added a commit to geoand/quarkus that referenced this issue Nov 24, 2022
@geoand
Add support for Kubernetes Client retry properties
74cdfad 
Closes: quarkusio#29467
@geoand geoand mentioned this issue Nov 24, 2022
Merged
@geoand
Copy link
Contributor

geoand commented Nov 24, 2022

Good idea! #29470 does just that

geoand added a commit that referenced this issue Nov 24, 2022
@geoand
Merge pull request #29470 from geoand/#29467
428ec9f 
Add support for Kubernetes Client retry properties
@quarkus-bot quarkus-bot bot added this to the 2.15 - main milestone Nov 24, 2022
@ManasMaji
Copy link
Author

Hi @geoand, thank you for adding the changes quickly! When can we expect this change to be released?

@geoand
Copy link
Contributor

geoand commented Nov 28, 2022

Hi,

They will be part of Quarkus 2.15, which should be released in a few weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/kubernetes kind/enhancement New feature or request
Projects
None yet
Milestone
2.15.0.CR1
Development

Successfully merging a pull request may close this issue.

Add support for Kubernetes Client retry properties geoand/quarkus
2 participants
@geoand @ManasMaji