Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus.kubernetes.namespace property shouldn't provoke overriding of already set namespaces on resources #29809

Closed
metacosm opened this issue Dec 12, 2022 · 1 comment · Fixed by #29813
Labels
area/kubernetes kind/bug Something isn't working
Milestone

Comments

@metacosm
Copy link
Contributor

Describe the bug

While not widely used at this time, it is possible for extensions to create additional / modify existing resources. It might happen that such resources need to be created in a different namespace than the one where most of the resources created by the Kubernetes extension (Deployment, Service, etc.) use. AddNamespaceDecorator, which handles the quarkus.kubernetes.namespace property, currently override any present namespace, thus potentially causing issues when extensions expect namespaces they set to remain untouched.

Expected behavior

If an extension sets a namespace on a resource, it is rather safe to assume that this value should be preserved and should therefore be left untouched when using quarkus.kubernetes.namespace.

Actual behavior

All namespaces are overridden by the quarkus.kubernetes.namespace value. Additionally, even manually provided resources defined in src/main/kubernetes also see their namespaces overridden.

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.15.0

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@metacosm metacosm added the kind/bug Something isn't working label Dec 12, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Dec 12, 2022

/cc @Sgitario, @geoand, @iocanel

metacosm added a commit to metacosm/quarkus that referenced this issue Dec 12, 2022
metacosm added a commit to metacosm/quarkus that referenced this issue Dec 13, 2022
gsmet pushed a commit to metacosm/quarkus that referenced this issue Dec 13, 2022
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 13, 2022
@gsmet gsmet modified the milestones: 2.16 - main, 2.15.1.Final Dec 20, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants