OpenAPI filters run twice when storing

[phillip-kruger]

          Yeah, so that is not ideal, I think we can get a better way to do this so that your filter is not run twice. I can look at this. Basically we need to create a document (for inclusion in the runtime), and then use that and only add runtime filters when we store.

I am about to take a break (summer holiday) so I'll only look at this next year. If you are in a hurry, you are welcome to do a PR ?

W.r.t priority, yeah that is something we can add. Having multiple filters is Quarkus specific (the spec only allow one) so from a spec p.o.w a user needs to do everything in one filter. But because we allow many we can look at a way to order them for sure

Originally posted by @phillip-kruger in #36152 (comment)

[quarkus-bot]

/cc @EricWittmann (openapi), @MikeEdgar (openapi)

[mcruzdev]

Hi @phillip-kruger, if you want, I can get this issue.

[phillip-kruger]

Go for it! Thanks

[mcruzdev]

Hi @phillip-kruger getting a first look into the code, I saw that the filter is called two times because:

The method responsible for executing filter is prepareOpenApiDocument(staticModel, annotationModel, openAPIBuildItems, index) and is called by:

1. loadDocument(OpenAPI staticModel, OpenAPI annotationModel, List<AddToOpenAPIDefinitionBuildItem> openAPIBuildItems, IndexView index)
2. storeDocument(OutputTargetBuildItem out, SmallRyeOpenApiConfig smallRyeOpenApiConfig, IndexView index, OpenAPI loadedModel, boolean includeRuntimeFilters)

I have a question:

The filter with RunStage OpenApiFilter.RunStage.BUILD should appear in http://localhost:8080/q/openapi download or just when generating via build or both?

[phillip-kruger]

Both

[mcruzdev]

Hi @phillip-kruger, HAY? Can you review the pull request #38070?

[phillip-kruger]

Away from PC at the moment, back next week