Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support image from local docker daemon for jib build base image #38320

Closed
HerrDerb opened this issue Jan 22, 2024 · 2 comments · Fixed by #38324
Closed

Support image from local docker daemon for jib build base image #38320

HerrDerb opened this issue Jan 22, 2024 · 2 comments · Fixed by #38324
Labels
area/container-image kind/enhancement New feature or request
Milestone
3.7.0

Comments

@HerrDerb
Copy link
Contributor

Description

Jib supports the usage of a local docker base image already since a while: GoogleContainerTools/jib#1468 (comment)

It seems that the same does not work when using the quarkus property to point to a local docker image quarkus.jib.base-native-image=docker://my-customquarkus-native-image:latest

It would be neat if quarkus would also support this, as we build the base image within the git workflow and would like to omit the push

Implementation ideas

No response
@HerrDerb HerrDerb added the kind/enhancement New feature or request label Jan 22, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 22, 2024

/cc @geoand (jib)

geoand added a commit to geoand/quarkus that referenced this issue Jan 22, 2024
@geoand
Support using tars as base image for Jib
3c95d6d 
Resolves: quarkusio#38320
@geoand geoand mentioned this issue Jan 22, 2024
Merged
@geoand
Copy link
Contributor

geoand commented Jan 22, 2024

Thanks, can you give #38324 a try?

@HerrDerb HerrDerb changed the title Support local docker base image for jib build Support image from local docker daemon for jib build base image Jan 22, 2024
geoand added a commit to geoand/quarkus that referenced this issue Jan 22, 2024
@geoand
Support using tars as base image for Jib
104c46b 
Resolves: quarkusio#38320
geoand added a commit to geoand/quarkus that referenced this issue Jan 22, 2024
@geoand
Support using tars as base image for Jib
60c5051 
Resolves: quarkusio#38320
geoand added a commit to geoand/quarkus that referenced this issue Jan 22, 2024
@geoand
Support using tars and docker and daemon as base image for Jib
a47821d 
Resolves: quarkusio#38320
geoand added a commit that referenced this issue Jan 22, 2024
@geoand
Merge pull request #38324 from geoand/#38320
4f11fdf 
Support using tars and docker daemon as base image for Jib
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Jan 22, 2024
@gsmet gsmet modified the milestones: 3.9 - main, 3.7.0 Jan 23, 2024
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jan 23, 2024
@geoand @gsmet
Support using tars and docker and daemon as base image for Jib
e59221d 
Resolves: quarkusio#38320
(cherry picked from commit a47821d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/container-image kind/enhancement New feature or request
Projects
None yet
Milestone
3.7.0
Development

Successfully merging a pull request may close this issue.

Support using tars and docker daemon as base image for Jib geoand/quarkus
3 participants
@gsmet @geoand @HerrDerb