Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RestEasy Reactive sends SameSite cookie param with wrong case #38465

Closed
stianst opened this issue Jan 30, 2024 · 1 comment · Fixed by #38466
Closed

RestEasy Reactive sends SameSite cookie param with wrong case #38465

stianst opened this issue Jan 30, 2024 · 1 comment · Fixed by #38466
Assignees
@geoand
Labels
area/resteasy-reactive kind/bug Something isn't working
Milestone
3.7.1

Comments

@stianst
Copy link
Contributor

stianst commented Jan 30, 2024 •
edited

Describe the bug

With RestEasy Reactive the Set-Cookie header uses the wrong case for SameSite parameter values:

Set-Cookie: ....; SameSite=LAX

RestEasy Classic on the other hand sets the correct case:

Set-Cookie: ....; SameSite=Lax

The NewCookieHeaderDelegate class that converts cookies into headers is not in sync between reactive and classic:

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response
@stianst stianst added the kind/bug Something isn't working label Jan 30, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 30, 2024

/cc @FroMage (resteasy-reactive), @geoand (resteasy-reactive), @stuartwdouglas (resteasy-reactive)

stianst added a commit to stianst/quarkus that referenced this issue Jan 30, 2024
@stianst
RestEasy Reactive sends SameSite cookie param with wrong case
a280efc 
Closes quarkusio#38465
@stianst stianst mentioned this issue Jan 30, 2024
Merged
@geoand geoand self-assigned this Jan 30, 2024
geoand added a commit to geoand/quarkus that referenced this issue Jan 30, 2024
@geoand
Fix case of SameSite cookie
d8239bb 
Fixes: quarkusio#38465
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Jan 30, 2024
@gsmet gsmet modified the milestones: 3.9 - main, 3.7.1 Jan 30, 2024
gsmet pushed a commit to gsmet/quarkus that referenced this issue Jan 30, 2024
@stianst @gsmet
RestEasy Reactive sends SameSite cookie param with wrong case
b4be787 
Closes quarkusio#38465

(cherry picked from commit a280efc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoand geoand

Labels
area/resteasy-reactive kind/bug Something isn't working
Projects
None yet
Milestone
3.7.1
Development

Successfully merging a pull request may close this issue.

Use proper case for SameSite cookie stianst/quarkus
3 participants
@gsmet @stianst @geoand