Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate that http and https are not on the same port #39289

Closed
shawkins opened this issue Mar 8, 2024 · 3 comments · Fixed by #39318
Closed

Validate that http and https are not on the same port #39289

shawkins opened this issue Mar 8, 2024 · 3 comments · Fixed by #39318
Labels
area/vertx kind/enhancement New feature or request
Milestone
3.9.0.CR1

Comments

@shawkins
Copy link
Contributor

shawkins commented Mar 8, 2024

Description

When starting the server with http and https enabled on the same port you see the message:

2024-03-08 07:55:52,523 INFO  [io.quarkus] (Quarkus Main Thread) getting-started 1.0.0-SNAPSHOT on JVM (powered by Quarkus 3.8.2) started in 1.499s. Listening on: http://localhost:8080 and https://localhost:8080

However https requests will fail with NPEs - see keycloak/keycloak#26603

It would be better if the server failed to start with an appropriate error.

Implementation ideas

No response
@shawkins shawkins added the kind/enhancement New feature or request label Mar 8, 2024
geoand added a commit to geoand/quarkus that referenced this issue Mar 11, 2024
@geoand
Fail to deploy application when http and https ports are the same
b0c8c09 
Vert.x seems not thrown any exception in this scenario, but it then
throws NPEs in either the secure or insecure handling of requests.
This behavior is very odd and provides users no good ways of diagnosing
the problem

Closes: quarkusio#39289
@geoand geoand mentioned this issue Mar 11, 2024
Merged
geoand added a commit to geoand/quarkus that referenced this issue Mar 11, 2024
@geoand
Fail to deploy application when http and https ports are the same
21adee6 
Vert.x seems not thrown any exception in this scenario, but it then
throws NPEs in either the secure or insecure handling of requests.
This behavior is very odd and provides users no good ways of diagnosing
the problem

Closes: quarkusio#39289
@geoand
Copy link
Contributor

geoand commented Mar 11, 2024

#39318 takes care of the problem

@shawkins
Copy link
Contributor Author

@geoand thank you, that will definitely help.

@geoand
Copy link
Contributor

geoand commented Mar 11, 2024

🙏🏼

geoand added a commit that referenced this issue Mar 11, 2024
@geoand
Merge pull request #39318 from geoand/#39289
04358cb 
Fail to deploy application when http and https ports are the same
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/vertx kind/enhancement New feature or request
Projects
None yet
Milestone
3.9.0.CR1
Development

Successfully merging a pull request may close this issue.

Fail to deploy application when http and https ports are the same geoand/quarkus
2 participants
@shawkins @geoand