Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] [3.8] Empty welcome page on new projects for old versions of Quarkus #39909

Closed
fedinskiy opened this issue Apr 5, 2024 · 7 comments · Fixed by #41254
Closed

[3.2] [3.8] Empty welcome page on new projects for old versions of Quarkus #39909

fedinskiy opened this issue Apr 5, 2024 · 7 comments · Fixed by #41254
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins kind/bug Something isn't working triage/wontfix This will not be worked on
Milestone

Comments

@fedinskiy
Copy link
Contributor

fedinskiy commented Apr 5, 2024

Describe the bug

When generated apps are downloaded from code.quarkus.io and run in dev mode, there is no welcome page("index.html" with "Congratualtions, you use Quarkus") on localhost.

Expected behavior

There should be a welcome page, just like for 3.9 and apps, downloaded from code.quarkus.redhat.com

Actual behavior

Http 404

How to Reproduce?

  1. Download an app: https://code.quarkus.io/api/download?e=quarkus-resteasy-reactive&S=3.2&j=17
  2. Unpack the zip
  3. Run mvn quarkus:dev
  4. Open localhost:8080 in a browser

If one downloads the latest version (eg https://code.quarkus.io/api/download?e=quarkus-resteasy-reactive&S=3.9&j=17) or uses RHBQ (https://code.quarkus.redhat.com/api/download?e=quarkus-resteasy-reactive&S=3.2&j=17) the welcome page is there

Output of uname -a or ver

6.7.3-200.fc39.x86_64

Output of java -version

Java version: 21.0.1, vendor: Eclipse Adoptium

Quarkus version or git rev

3.8.1

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)

Additional information

Probably related to #37680

@fedinskiy fedinskiy added the kind/bug Something isn't working label Apr 5, 2024
@fedinskiy fedinskiy changed the title Empty welcome page for old version of Quarkus Empty welcome page for old versions of Quarkus Apr 5, 2024
@geoand geoand added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins and removed triage/needs-triage labels Apr 8, 2024
@geoand
Copy link
Contributor

geoand commented Apr 8, 2024

cc @ia3andy

@ia3andy
Copy link
Contributor

ia3andy commented Apr 8, 2024

Yeah, this is known. I didn't find a simple way to solve this :-/

For context, the default page is now dynamic and handled by Quarkus, since the codestarts are using a set of base codestarts the index.html is not there anymore and this affect all versions.

@ia3andy ia3andy added the triage/wontfix This will not be worked on label Apr 8, 2024
@rsvoboda
Copy link
Member

rsvoboda commented Apr 8, 2024

So codestarts are shared across all the streams @ia3andy ?

@fedinskiy fedinskiy changed the title Empty welcome page for old versions of Quarkus [3.2] [3.8] Empty welcome page for old versions of Quarkus Apr 8, 2024
@ia3andy
Copy link
Contributor

ia3andy commented Apr 8, 2024

So codestarts are shared across all the streams @ia3andy ?

There is a shared base yeah: https://github.com/quarkusio/quarkus/tree/main/independent-projects/tools/base-codestarts/src/main/resources/codestarts/quarkus

@ia3andy ia3andy changed the title [3.2] [3.8] Empty welcome page for old versions of Quarkus [3.2] [3.8] Empty welcome page on new projects for old versions of Quarkus Apr 8, 2024
fedinskiy added a commit to fedinskiy/quarkus-startstop that referenced this issue Apr 9, 2024
fedinskiy added a commit to fedinskiy/quarkus-startstop that referenced this issue Apr 10, 2024
fedinskiy added a commit to fedinskiy/quarkus-startstop that referenced this issue Apr 11, 2024
@michalvavrik
Copy link
Contributor

When I create 3.8.x application with Quarkus CLI on Linux with Quarkus CLI version 3.8.3 then localhost:8080/ in DEV Mode index is there and when I create the same application with Quarkus CLI snapshot, it's not there.

@maxandersen
Copy link
Contributor

@ia3andy why can't the generation be based on what version is targeted ? that must be possible otherwise can never adjust behavior like what was now apparently done with dynamic index page.

even if we can't find it for generic resources we are now at least forced to do it for index.html generation.

@ia3andy
Copy link
Contributor

ia3andy commented Jun 17, 2024

@ia3andy why can't the generation be based on what version is targeted ? that must be possible otherwise can never adjust behavior like what was now apparently done with dynamic index page.

even if we can't find it for generic resources we are now at least forced to do it for index.html generation.

I will try to find a way to fix it with new CLI when creating project for older versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins kind/bug Something isn't working triage/wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants