Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to inject a configured REST client for testing #569

Closed
emmanuelbernard opened this issue Jan 18, 2019 · 2 comments
Closed

Ability to inject a configured REST client for testing #569

emmanuelbernard opened this issue Jan 18, 2019 · 2 comments
Labels
kind/enhancement New feature or request
Milestone

Comments

@emmanuelbernard
Copy link
Member

From Goergios Andrianakis

Also, wouldn't it make sense to have the ability to inject a pre-configured
rest client into the integration test so the user doesn't have to do that
(I'm thinking something as simple as configuring a RestAssured client with
the port where Protean started)?

@geoand
Copy link
Contributor

geoand commented Jan 18, 2019

Relates to #553

@stuartwdouglas
Copy link
Member

This is easy to do for JVM based testing, but it does not really work for Substrate, as it is not really possible to get the port from the native image without reverting to some pretty nasty hacks (e.g. logging the port and parsing the console output).

If it is a fixed port we could potentially just get it from the config file at test time, however this won't work for port 0

@cescoffier cescoffier added the kind/enhancement New feature or request label Feb 14, 2019
@cescoffier cescoffier added this to the 0.9.0 milestone Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants