-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push Flyway integration to the next level #6240
Labels
Milestone
Comments
There is |
Would you be willing to contribute some of that? It doesn’t look too hard. |
It would be great if you could contribute @x80486, Here is a small diff of how git a/extensions/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/FlywayCreator.java b/extensions/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/FlywayCreator.java
index 0f0ea851e..cb65d82ab 100644
--- a/extensions/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/FlywayCreator.java
+++ b/extensions/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/FlywayCreator.java
@@ -26,6 +26,8 @@ class FlywayCreator {
flywayRuntimeConfig.repeatableSqlMigrationPrefix.ifPresent(configure::repeatableSqlMigrationPrefix);
configure.baselineOnMigrate(flywayRuntimeConfig.baselineOnMigrate);
+ configure.validateOnMigrate(flywayRuntimeConfig.validateOnMigrate);
+
flywayRuntimeConfig.baselineVersion.ifPresent(configure::baselineVersion);
flywayRuntimeConfig.baselineDescription.ifPresent(configure::baselineDescription);
diff --git a/extensions/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/FlywayDataSourceRuntimeConfig.java b/extensions/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/FlywayDataSourceRuntimeConfig.java
index dbf08839a..3bd9d8e46 100644
--- a/extensions/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/FlywayDataSourceRuntimeConfig.java
+++ b/extensions/flyway/runtime/src/main/java/io/quarkus/flyway/runtime/FlywayDataSourceRuntimeConfig.java
@@ -82,6 +82,13 @@ public final class FlywayDataSourceRuntimeConfig {
@ConfigItem
public boolean baselineOnMigrate;
+ /**
+ * TODO: Add Javadoc
+ */
+ @ConfigItem
+ public boolean validateOnMigrate;
+
/**
* The initial baseline version.
*/
|
OK, I'll take it 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Since Quarkus has already support for Flyway, it would be great to support some other "operations" (or commands) to make our life easier while dealing with it:
quarkus.flyway.validate-on-migrate
— Option to automatically callvalidate
when performing the migrationquarkus.flyway.out-of-order
— Allow migrations to be run out of order or notquarkus.flyway.clean-disabled
— Whether to disable cleaning of the database; extremely useful during development and when tests are about (or prepared to) be run, so we don't have to do this manually all the timeThe text was updated successfully, but these errors were encountered: