Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom properties for Knative generation #7788

Closed
lordofthejars opened this issue Mar 11, 2020 · 3 comments · Fixed by #13117
Closed

Create custom properties for Knative generation #7788

lordofthejars opened this issue Mar 11, 2020 · 3 comments · Fixed by #13117
Assignees
Labels
kind/enhancement New feature or request
Milestone

Comments

@lordofthejars
Copy link
Contributor

Description

Currently, if you want to customize the output generated by Dekorate for Knative, you only have access to the same properties as in the Kubernetes (https://github.com/quarkusio/quarkus/blob/master/docs/src/main/asciidoc/kubernetes.adoc#knative) but with knative prefix.

The thing is that minimal customizations specific to knative service should be provided, the list is in https://knative.dev/docs/serving/spec/knative-api-specification-1.0/#service I know that not all of them should be implemented, but at least some of most used would be interesting to provide it.

Implementation ideas

Implement custom Knative serving attributes to be able to customize the output.

@lordofthejars lordofthejars added the kind/enhancement New feature or request label Mar 11, 2020
@geoand
Copy link
Contributor

geoand commented Mar 11, 2020

cc @iocanel

@iocanel iocanel self-assigned this Mar 12, 2020
@iocanel
Copy link
Contributor

iocanel commented Mar 12, 2020

Some of the things we need to cover:

  • Use Knative V1
  • Cluster local services
  • Allow setting traffic splitting rules
  • Configure autoscaling requirements

@lordofthejars: If there are other areas, you'd like to cover please add them.

@lordofthejars
Copy link
Contributor Author

lordofthejars commented Mar 12, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants