Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Simplify fast jar dockerfiles by only using a single copy com… #10892

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

stuartwdouglas
Copy link
Member

…mand."

This reverts commit cc4435c.

The multiple copy commands are deliberate, as they result in different layers being created. This means that if you only change your application code and not your libraries only the changed part of the application needs to be shipped on deployment.

@boring-cyborg boring-cyborg bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Jul 22, 2020
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right 👍

@gsmet
Copy link
Member

gsmet commented Jul 22, 2020

Ah, sorry about that. Could we add a comment in the Dockerfiles for posterity?

@stuartwdouglas
Copy link
Member Author

done

@gastaldi gastaldi added this to the 1.7.0 - master milestone Jul 23, 2020
@gastaldi gastaldi merged commit 4018e6e into quarkusio:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants