Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registers RestClientListener for reflection and adds service file as a native resource #11455

Merged
merged 1 commit into from Aug 20, 2020
Merged

Registers RestClientListener for reflection and adds service file as a native resource #11455

merged 1 commit into from Aug 20, 2020

Conversation

kenfinnigan
Copy link
Member

@kenfinnigan kenfinnigan commented Aug 18, 2020 •
edited by gastaldi

  • Registers RestClientListener for reflection and adds service file as a native resource

Fixes #11349

@kenfinnigan
Copy link
Member Author

Did this fail because of hitting a time limit?

@Ladicek
Copy link
Contributor

Ladicek commented Aug 19, 2020

FYI, GitHub doesn't notice the issue number when it's not in the 1st comment of the PR. (And it probably has to be there during PR creation, because when I added it retroactively in some of my PRs elsewhere, it didn't work.)

@kenfinnigan
Copy link
Member Author

@gsmet do you happen to know why the CI build just stopped? Nothing obvious to me in the CI details

@kenfinnigan
Fixes quarkusio#11349
d05fadf 
- Registers RestClientListener for reflection and adds service file as a native resource
rsvoboda
rsvoboda approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 spans in case of native mode, 3 spans in case of jvm mode
Checked with tracing-sample reproducer

@gastaldi gastaldi changed the title Fixes #11349 Registers RestClientListener for reflection and adds service file as a native resource Aug 20, 2020
@jaikiran
Copy link
Member

Hello @kenfinnigan, both the failed jobs are failing due to unrelated reasons of the form:

2020-08-19T16:04:38.4842075Z ##[section]Starting: Request a runner to run this job
2020-08-19T16:04:39.7916975Z Can't find any online and idle self-hosted runner in current repository that matches the required labels: 'ubuntu-latest'
2020-08-19T16:04:39.7917120Z Can't find any online and idle self-hosted runner in current repository's account/organization that matches the required labels: 'ubuntu-latest'
2020-08-19T16:04:39.7917372Z Found online and idle hosted runner in current repository's account/organization that matches the required labels: 'ubuntu-latest'
2020-08-19T16:04:40.1329972Z ##[section]Finishing: Request a runner to run this job

@gsmet gsmet merged commit 12937bc into quarkusio:master Aug 20, 2020
@gsmet gsmet added this to the 1.8.0 - master milestone Aug 20, 2020
@kenfinnigan
Copy link
Member Author

Thanks @jaikiran, couldn't easily see that from where I was looking

@kenfinnigan kenfinnigan deleted the native-tracing branch August 20, 2020 12:20
@gsmet gsmet modified the milestones: 1.8.0 - master, 1.7.1.Final Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsvoboda rsvoboda rsvoboda approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/rest-client
Projects
None yet
Milestone
1.7.1.Final
Development

Successfully merging this pull request may close these issues.

Multiple traces in Native mode instead of one trace with multiple spans like in JVM mode
5 participants
@kenfinnigan @Ladicek @jaikiran @rsvoboda @gsmet