More reactive SQL client connection options #11498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Aug 20, 2020
...me/src/main/java/io/quarkus/reactive/datasource/runtime/DataSourceReactiveRuntimeConfig.java
Outdated
Show resolved
Hide resolved
|
@machi1990 we have a doc generation issue with the duration note. We include it twice in the datasource.doc now that we have it included here too. I don't exactly know how we could fix that as these things are generated totally independently. |
tsegismont
force-pushed
the
more-sql-connect-options
branch
from
64e34d5
to
39c5a9f
Compare
|
I will try to figure out how to fix the doc issue. |
|
Thanks
Le jeu. 20 août 2020 à 16:07, Guillaume Smet <notifications@github.com> a
écrit :
… I will try to figure out how to fix the doc issue.
|
This is useful when you have several config references included in the same document and you only want one note. We can probably do better but I prefer to have a quick fix to unblock this PR.
…eactive datasource config
gsmet
force-pushed
the
more-sql-connect-options
branch
from
39c5a9f
to
238e305
Compare
|
I added a quick (and dirty) fix for the doc issue. Let's see what CI says. |
gsmet
approved these changes
Aug 20, 2020
gsmet
added
the
triage/waiting-for-ci
@gsmet @tsegismont sorry only seeing this comment now. Good thing we had a fix in place :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added reconnectAttempts, reconnectInterval and idleTimeout props to reactive datasource config
Resolves #11149