1.7.0.Final quarkus.package.output-directory causes NPE running tests #11626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gastaldi
reviewed
Aug 25, 2020
| outputDir = projectRoot.resolve(projectRoot.relativize(testClassLocation).getName(0)); | ||
| } catch (Exception e) { | ||
| // this shouldn't happen since testClassLocation is usually found under the project dir | ||
| outputDir = projectRoot; |
There was a problem hiding this comment.
It would be nice to log.debug this exception, just in case
There was a problem hiding this comment.
I am not sure it's worth it. It would mean the project has an usual layout and if so, the user is very much aware of that w/o us logging stacktraces. There is a lot of garbage in the debug output w/o it. Second, this outputDir for QuarkusTest's isn't normally used at all, we are not packaging anything.
aloubyansky
force-pushed
the
quarkus-package-output-dir
branch
from
a98e186
to
0a876b5
Compare
gastaldi
approved these changes
Aug 26, 2020
aloubyansky
force-pushed
the
quarkus-package-output-dir
branch
from
0a876b5
to
072da09
Compare
|
@aloubyansky I saw you force pushed a few times, is this one ready to go in? |
|
Yes, i did that just to restart the CI hoping it'd pass. |
|
Yeah, no need for that, it won't, unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11400