Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize duration default values rendered in documentation #11907

Merged
merged 1 commit into from Sep 7, 2020

Conversation

knutwannheden
Copy link
Contributor

The duration default values rendered in the documentation are now normalized by appending an S to any default value which is a number only. Additionally the duration values are all converted to upper-case.

Fixes #10022

The duration default values rendered in the documentation are now normalized by appending an `S` to any default value which is a number only. Additionally the duration values are all converted to upper-case.

Fixes quarkusio#10022
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR and for adding unit tests.

@gastaldi gastaldi added this to the 1.9.0 - master milestone Sep 7, 2020
@gastaldi gastaldi merged commit 65c5a32 into quarkusio:master Sep 7, 2020
@gsmet gsmet modified the milestones: 1.9.0 - master, 1.8.0.Final Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration properties of type duration should include the unit when rendering the default value
4 participants