Deprecate OIDC xhr-auto-redirect and add java-script-auto-redirect properties #12399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sberyozkin
force-pushed
the
rename_xhr_auto_redirect
branch
from
0c4b509
to
442eb9a
Compare
pedroigor
approved these changes
Sep 29, 2020
|
@sberyozkin So we still check for |
|
Hey @pedroigor I was thinking of just deleting the deprecated property, but the docs themselves only mention XHR as one of the possible producers of the new header value |
|
Hi @pedroigor OK, merging now, but ping me please if you'd like some doc updates be done :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users who need to manually handle redirects in their SPA applications use
Fetch, see this Zulip thread, so asking them to setquarkus.oidc.authentication.xhr-auto-redirect=falseis not nice :-),so this PR deprecates
quarkus.oidc.authentication.xhr-auto-redirectand addsquarkus.oidc.authentication.javascript-auto-redirectwhich should be general enough for all the cases where SPA which use some JavaScript API need to disable the auto-redirect.Also, this PR adds a minor update related to the non-OIDC server case (where only public-key is configured), so it Fixes #12395