Add Vertx web extension #1311
Merged
Add Vertx web extension #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
approved these changes
Mar 11, 2019
...ions/vertx-web/runtime/src/main/java/io/quarkus/vertx/web/runtime/HttpServerInitializer.java
Show resolved
Hide resolved
...ions/vertx-web/runtime/src/main/java/io/quarkus/vertx/web/runtime/HttpServerInitializer.java
Show resolved
Hide resolved
|
@cescoffier I added the RX Router producer but I wasn't able to find the Axle version? Now it's also possible to change the |
|
You are right we don't have the Axle API yet, my mistake. |
- make it possible to (1) define routes both in a declarative way and programatically, (2) inject Router and observe Router during http server startup - fire HttpServerOptions event to allow users to configure the server programmatically HOT REPLACEMENT DOES NOT WORK YET
|
Hot replacement does not work yet. I'll need to ask Stuart about some magic he did for Undertow... |
|
Merging like it is, we need to have a better approach for the hot-reload. |
cescoffier
added
kind/enhancement
|
@cescoffier well, it wasn't ready for merge yet ;-). But I think I know where the problem was and I'll try to send a follow-up PR this morning. |
gsmet
added
release/noteworthy-feature
kind/new-feature
and removed
kind/enhancement
|
@mkouba @cescoffier Very cool! |
|
The hot reload has been added in #1587 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
programatically, (2) inject Router and observe Router during
http server startup
Supersedes #1041