Vert.x event-loop threads start as "vert.x-eventloop-thread-" #13143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This typo causes a bug where blocking checks fail when run on a Vert.x event-loop.
|
This is a stupid bug, sorry for the mistake. |
|
/cc @cescoffier |
gsmet
reviewed
Nov 5, 2020
| @@ -36,7 +36,7 @@ public boolean getAsBoolean() { | |||
| * calling from a Vert.x event-loop context / thread. | |||
| */ | |||
| String threadName = Thread.currentThread().getName(); | |||
| return !threadName.contains("vertx-eventloop-thread-"); | |||
| return !threadName.startsWith("vert.x-eventloop-thread-"); | |||
There was a problem hiding this comment.
Couldn't we have a constant in Vert.x or an API to test that?
There was a problem hiding this comment.
No, because this would add dependency from this extension to Vert.x core. I had initially tried writing the test with Vert.x APIs, but that didn't work here.
There was a problem hiding this comment.
Note that this naming scheme has been consistent over the years and is not changing anytime soon.
There was a problem hiding this comment.
We want to avoid having an explicit dependency on Vert.x. I believe there is a comment about that.
That being said, we can create a constant.
jponge
force-pushed
the
bug/mutiny-blocking-vertx-check
branch
from
a2a2a74
to
5332dc7
Compare
|
@cescoffier I let you check and merge this one. Thanks! |
cescoffier
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This typo causes a bug where blocking checks fail when run on a Vert.x event-loop.