Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update removeExtension gradle tests to fix CI #13217

Merged
merged 1 commit into from Nov 11, 2020

Conversation

glefloch
Copy link
Member

The snapshot ci job and the release test job are both failing due to failed gradle tests.

All failed tests are happening on ./gradlew removeExtension --extensions="hibernate-orm".

From what I saw, the remove extension command fails with the following exception:

  Could not resolve all files for configuration ':runtimeClasspath'.
      > Could not find javax.persistence-api-2.2.jar (javax.persistence:javax.persistence-api:2.2).
         Searched in the following locations:
             file:/Users/glefloch/.m2.tmp/repo/javax/persistence/javax.persistence-api/2.2/javax.persistence-api-2.2.jar

this dependency is a transitive dependency of the hibernate-orm extension previously added in the test. This exception is thrown at

at io.quarkus.gradle.builder.QuarkusModelBuilder.collectDependencies(QuarkusModelBuilder.java:329)

When looking in my maven repo, the jar is missing, the pom is present and there is a _remote.repositories with the following content:

#NOTE: This is a Maven Resolver internal implementation file, its format can be changed without prior notice. 
#Tue Nov 10 14:42:04 CET 2020
javax.persistence-api-2.2.pom>central=

Removing this file fix tests.

In order to avoid failures, I updated tests to use the openshift extension instead of the hibernate-orm extension.
The Release test job is green on my fork.

If you have some explanation about that, I would be happy to understand :) and if you have any other alternative, that would be great!

@ghost ghost added the area/gradle Gradle label Nov 10, 2020
@aloubyansky
Copy link
Member

Caused by: org.apache.maven.plugin.MojoFailureException: File '/home/runner/work/quarkus/quarkus/integration-tests/gradle/src/test/java/io/quarkus/gradle/AddExtensionToSingleModuleKtsProjectTest.java' has not been previously formatted.  Please format file and commit before running validation!

@glefloch glefloch force-pushed the fix/gradle-remove-extension-tests branch from 1eaaa03 to 880100d Compare November 10, 2020 20:44
@glefloch
Copy link
Member Author

glefloch commented Nov 10, 2020

I updated the code, should be good now. Sorry for that.

@gsmet gsmet merged commit 66136bc into quarkusio:master Nov 11, 2020
@ghost ghost added this to the 1.11 - master milestone Nov 11, 2020
@gsmet gsmet modified the milestones: 1.11 - master, 1.10.0.Final Nov 13, 2020
@glefloch glefloch deleted the fix/gradle-remove-extension-tests branch August 19, 2021 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants