New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gradle test assertion #13250
Fix gradle test assertion #13250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering how this did pass the CI.
Hum. Yeah, I think we need to understand how it passed CI. |
It looks like tests overlap themselves. Running test with |
I'm torn about this one. We have CI green and we're changing a test and CI is still green. We need to get to the bottom of this. |
b39864f
to
1e93bf2
Compare
I reverted the test fix and even with the |
46010f6
to
27cb401
Compare
e993f97
to
5ccb205
Compare
09eff10
to
75f8fc0
Compare
75f8fc0
to
c51fb29
Compare
I pushed the commit that only fixed the test. I tested multiple things but I was never able to make the test fail in CI. The only difference between the main ci job and the snapshot job (that fails) is the cache but I don't know how it could be related. have you any idea @gsmet @aloubyansky ? |
I'll try to reproduce it one of these days. |
Let's see if it improves the snapshot deployment situation. |
The test assertion was wrong but the ci was OK.
I fixed the test.