Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradle test assertion #13250

Merged
merged 1 commit into from Nov 23, 2020
Merged

Conversation

glefloch
Copy link
Member

The test assertion was wrong but the ci was OK.
I fixed the test.

@ghost ghost added the area/gradle Gradle label Nov 12, 2020
Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering how this did pass the CI.

@gsmet
Copy link
Member

gsmet commented Nov 12, 2020

Hum. Yeah, I think we need to understand how it passed CI.

@glefloch
Copy link
Member Author

It looks like tests overlap themselves. Running test with maxParallelForks = 1 shows the error. I set the flag in the test task.

@gsmet
Copy link
Member

gsmet commented Nov 13, 2020

I'm torn about this one. We have CI green and we're changing a test and CI is still green.

We need to get to the bottom of this.

@glefloch
Copy link
Member Author

I reverted the test fix and even with the maxParallelForks = 1, CI is green..
Should I open an issue ?

@glefloch glefloch force-pushed the fix/ci-gradle-test branch 2 times, most recently from 46010f6 to 27cb401 Compare November 20, 2020 14:01
@ghost ghost added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Nov 20, 2020
@glefloch glefloch force-pushed the fix/ci-gradle-test branch 2 times, most recently from e993f97 to 5ccb205 Compare November 21, 2020 09:55
@ghost ghost added the area/testing label Nov 21, 2020
@glefloch glefloch force-pushed the fix/ci-gradle-test branch 2 times, most recently from 09eff10 to 75f8fc0 Compare November 22, 2020 14:27
@glefloch
Copy link
Member Author

I pushed the commit that only fixed the test.

I tested multiple things but I was never able to make the test fail in CI.
On my local machine, the test with the wrong assertion always fail.
First, I thought there was some kind of race condition as tests may run in parallel, I tried running them sequentially but the test was still ok, I even tried to only run this test, and it's still ok.
I tried to migrate it in java but always ok.

The only difference between the main ci job and the snapshot job (that fails) is the cache but I don't know how it could be related.

have you any idea @gsmet @aloubyansky ?

@aloubyansky
Copy link
Member

I'll try to reproduce it one of these days.

@gsmet gsmet merged commit 2b4bafe into quarkusio:master Nov 23, 2020
@ghost ghost added this to the 1.11 - master milestone Nov 23, 2020
@gsmet
Copy link
Member

gsmet commented Nov 23, 2020

Let's see if it improves the snapshot deployment situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants