Create a new Resteasy Context Map #13335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
geoand
approved these changes
Nov 17, 2020
cescoffier
approved these changes
Nov 17, 2020
FroMage
requested changes
Nov 17, 2020
| Map<Class<?>, Object> map = new HashMap<>(); | ||
| map.put(SecurityContext.class, new QuarkusResteasySecurityContext(request, routingContext)); | ||
| map.put(RoutingContext.class, routingContext); | ||
| ResteasyContext.pushContextDataMap(map); |
There was a problem hiding this comment.
I think you should be using the variant that creates a new Closeable context : addCloseableContextDataLevel that you can use in a try-with-resource.
There was a problem hiding this comment.
What about async requests?
There was a problem hiding this comment.
Async requests need to capture this context anyway, since we've no idea what thread they'll be in when they get executed. This doesn't destroy anything, BTW. It just pops it from the current context stack and restore the previous context map.
This provides a slight performance advantage, but most importantly will prevent an existing client context from interfering with the server one. This can happen if the authentication layer is using the REST client to access external services. Fixes quarkusio#13317
stuartwdouglas
force-pushed
the
13317
branch
from
8eab583
to
912d62e
Compare
FroMage
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a slight performance advantage,
but most importantly will prevent an existing
client context from interfering with the server one.
This can happen if the authentication layer is using
the REST client to access external services.
Fixes #13317