Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing quarkus-openshift-client dependencies in application bom #13350

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Missing quarkus-openshift-client dependencies in application bom #13350

merged 1 commit into from
Nov 18, 2020

Conversation

vsevel
Copy link
Contributor

@vsevel vsevel commented Nov 18, 2020

No description provided.

@ghost ghost added the area/dependencies Pull requests that update a dependency file label Nov 18, 2020
geoand
geoand approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added triage/backport? triage/waiting-for-ci Ready to merge when CI successfully finishes labels Nov 18, 2020
@vsevel
Copy link
Contributor Author

vsevel commented Nov 18, 2020

@geoand I have added another one: quarkus-test-openshift-client

gsmet
gsmet approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@gsmet gsmet merged commit f57aa70 into quarkusio:master Nov 18, 2020
@ghost ghost added this to the 1.11 - master milestone Nov 18, 2020
@gsmet gsmet modified the milestones: 1.11 - master, 1.10.0.Final Nov 18, 2020
@vsevel vsevel deleted the dep_mgmt_openshift_client branch November 18, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.10.0.Final
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vsevel @gsmet @geoand