Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to smallrye-jwt-2.4.0 #13497

Merged
merged 1 commit into from Nov 28, 2020
Merged

Update to smallrye-jwt-2.4.0 #13497

merged 1 commit into from Nov 28, 2020

Conversation

sberyozkin
Copy link
Member

No description provided.

@sberyozkin sberyozkin added this to the 1.11 - master milestone Nov 26, 2020
@ghost ghost added area/dependencies Pull requests that update a dependency file area/documentation labels Nov 26, 2020
@sberyozkin sberyozkin mentioned this pull request Nov 26, 2020
Closed
gastaldi
gastaldi reviewed Nov 27, 2020
View reviewed changes
docs/src/main/asciidoc/security-jwt.adoc Outdated
<dependency>
<groupId>io.smallrye</groupId>
<artifactId>smallrye-jwt-build</artifactId>
<version>${smallrye.jwt.version}</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the version still necessary here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gastaldi Sorry, missed this question - I don't know - it is not in Quarkus bom/application/pom.xml dependencies management section yet as at the moment quarkus-smallrye-jwt/quarkus-oidc depend on it indirectly.
I can update this section later, as part of the fix for #13499, to include io.quarkus/quarkus-smallrye-jwt-build (no version) ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding it to the BOM should be done in the same commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you can remove the version now from here now as it will automatically come with the BOM.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gsmet, yeah, sorry, I realized it once I switched my laptop off and went for a walk :-), sorry :-)

gsmet
gsmet requested changes Nov 27, 2020
View reviewed changes
docs/src/main/asciidoc/security-jwt.adoc Outdated
<dependency>
<groupId>io.smallrye</groupId>
<artifactId>smallrye-jwt-build</artifactId>
<version>${smallrye.jwt.version}</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adding it to the BOM should be done in the same commit.

@sberyozkin
Copy link
Member Author

@gastaldi @gsmet, ok, np, I suppose even at this stage it would be easier for the users to have it in the BOM

@gsmet gsmet merged commit 8ec3f04 into quarkusio:master Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi left review comments

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/documentation
Projects
None yet
Milestone
1.11.0.Beta1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sberyozkin @gastaldi @gsmet