Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runtime classloader micro optimisations #13503

Merged
merged 5 commits into from Nov 27, 2020
Merged

Runtime classloader micro optimisations #13503

merged 5 commits into from Nov 27, 2020

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Nov 26, 2020

Some small polishing to the RuntimeClassLoader. Mostly a follow-up to #13383 as I was having a look.

@Sanne Sanne requested a review from geoand November 26, 2020 22:19
@ghost ghost added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Nov 26, 2020
geoand
geoand reviewed Nov 27, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Sanne.

I added a small comment.

...t-projects/bootstrap/runner/src/main/java/io/quarkus/bootstrap/runner/RunnerClassLoader.java Outdated Show resolved Hide resolved
geoand
geoand approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@geoand geoand added this to the 1.11 - master milestone Nov 27, 2020
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Nov 27, 2020
@Sanne Sanne mentioned this pull request Nov 27, 2020
Merged
geoand added a commit to geoand/quarkus that referenced this pull request Nov 27, 2020
@geoand
Remove the protection domain map in RunnerClassLoader
e9ea5e5 
Based on: quarkusio#13503 (comment)
@geoand geoand mentioned this pull request Nov 27, 2020
Merged
geoand added a commit to geoand/quarkus that referenced this pull request Nov 27, 2020
@geoand
Remove the protection domain map in RunnerClassLoader
4ad9172 
Based on: quarkusio#13503 (comment)
@Sanne Sanne merged commit a2a8e47 into quarkusio:master Nov 27, 2020
@Sanne Sanne deleted the RuntimeClassloaderP branch November 27, 2020 15:07
geoand added a commit to geoand/quarkus that referenced this pull request Nov 27, 2020
@geoand
Remove the protection domain map in RunnerClassLoader
88e6c71 
Based on: quarkusio#13503 (comment)
geoand added a commit to geoand/quarkus that referenced this pull request Nov 27, 2020
@geoand
Remove the protection domain map in RunnerClassLoader
d6d4de4 
Based on: quarkusio#13503 (comment)
geoand added a commit to geoand/quarkus that referenced this pull request Dec 1, 2020
@geoand
Remove the protection domain map in RunnerClassLoader
a94be26 
Based on: quarkusio#13503 (comment)
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this pull request Sep 4, 2022
Remove the protection domain map in RunnerClassLoader
ea508b7 
    Based on: quarkusio/quarkus#13503 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.11.0.Beta1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sanne @gsmet @geoand