Update Keycloak Authorization docs and UserInfo #13659
Conversation
ghost
added
the
| @@ -40,7 +42,9 @@ public String userNameService(@PathParam("tenant") String tenant) { | |||
| String name = getNameServiceType(); | |||
| if ("tenant-d".equals(tenant) || "tenant-b-no-discovery".equals(tenant)) { | |||
| UserInfo userInfo = getUserInfo(); | |||
| name = name + "." + userInfo.getString("preferred_username"); | |||
| if (userInfo.getPropertyNames().contains(PREFERRED_USERNAME)) { | |||
There was a problem hiding this comment.
Instead of returning the property names via a getter, isn't better to introduce a UserInfo.contains(String) instead?
There was a problem hiding this comment.
@gastaldi the user just wanted to see the whole set of property names as he was not sure what is in that UserInfo, here I just added this awkward check to test the new method :-), but yeah, let me add a shortcut as well, makes sense
There was a problem hiding this comment.
@gastaldi Just updated it, kept the getPropertyNames test check but also added contains check
sberyozkin
force-pushed
the
minor_oidc_fixes
branch
from
fb1c70c
to
249b22e
Compare
|
@gastaldi Only MP TCK tests have stalled which is not related; I'll just go ahead with merging it to have a feeling I've done at least something today :-) |
| @@ -318,7 +318,7 @@ public class ProtectedResource { | |||
| @GET | |||
| public CompletionStage<List<Permission>> get() { | |||
| return identity.checkPermission(new AuthPermission("{resource_name}")) | |||
| .thenCompose(granted -> { | |||
| .transform(granted -> { | |||
There was a problem hiding this comment.
Missing onItem() before calling .transform(.
There was a problem hiding this comment.
Going to update it shortly
Fixes #13652
Also a user reported that it was impossible to get a list of all the UserInfo properties