Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MongoDB read preferences by query #13824

Merged
merged 1 commit into from Dec 16, 2020
Merged

MongoDB read preferences by query #13824

merged 1 commit into from Dec 16, 2020

Conversation

loicmathieu
Copy link
Contributor

@loicmathieu loicmathieu commented Dec 10, 2020 •
edited

Fixes #10909

@ghost
Copy link

ghost commented Dec 10, 2020

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)
  • title should not start with chore/feat/fix/docs but be a proper sentence

This message is automatically generated by a bot.

@loicmathieu
Copy link
Contributor Author

@evanchooly before I finish this one I wanted to have you take on this one.

To be able to set read preferences for a query as we discussed on #10909 we need to use the withReadPreference method on the collection itself. I don't know if it has some caveats or not so I wanted your opinion on this one.

Some day, transaction will arrives to MongoDB with Panache ( see #10097) and it will also allows to set read preferences but at the transaction level so maybe it'll be enought and we can not implement this one.

@loicmathieu loicmathieu changed the title feat: mongdb read preferences by query Mongdb read preferences by query Dec 10, 2020
@evanchooly
Copy link
Member

comments inlined.

@loicmathieu loicmathieu marked this pull request as ready for review December 11, 2020 12:24
@evanchooly
Copy link
Member

LGTM but it look like you need to run the formatter over the tree.

@loicmathieu
Copy link
Contributor Author

@evanchooly thanks, strange I may have forgot to run it on one lib. Should be fixed now.

@loicmathieu loicmathieu added this to the 1.11 - master milestone Dec 11, 2020
@gsmet gsmet changed the title Mongdb read preferences by query MongoDB read preferences by query Dec 16, 2020
@gsmet gsmet merged commit 797d1dc into quarkusio:master Dec 16, 2020
@loicmathieu loicmathieu deleted the feat/mongodb-readpreference branch June 25, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanchooly evanchooly evanchooly approved these changes

Assignees
No one assigned
Labels
area/mongodb area/panache
Projects
None yet
Milestone
1.11.0.Beta1
Development

Successfully merging this pull request may close these issues.

MongoDB ReadPreferences Configuration per collection
3 participants
@loicmathieu @evanchooly @gsmet