Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 'inherit' logging min-level settings #14326

Merged
merged 2 commits into from Jan 18, 2021

Conversation

galderz
Copy link
Member

@galderz galderz commented Jan 15, 2021

Closes #14154. This PR replaces #14160.

Fixed by searching through parent categories until a non-inherit one is found, or use default category instead.

@galderz galderz requested a review from dmlloyd January 15, 2021 16:12
johnpoth added a commit to johnpoth/quarkus that referenced this pull request Jan 15, 2021
Copy link
Member

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me, though there is a CI failure it seems.

* Handle 'inherit' min-level settings,
by searching through parent categories
until the actual level is found.
@galderz
Copy link
Member Author

galderz commented Jan 15, 2021

Fixed the formatting.

@gsmet gsmet merged commit 5018a9f into quarkusio:master Jan 18, 2021
@ghost ghost added this to the 1.12 - master milestone Jan 18, 2021
@gsmet
Copy link
Member

gsmet commented Jan 18, 2021

Thanks!

@gsmet gsmet modified the milestones: 1.12 - master, 1.11.1.Final Jan 18, 2021
@galderz galderz deleted the t_inherit_14154_v4 branch March 18, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: using inherit in quarkus.log.category fails with an exception
3 participants