Dev mode - fix instrumentation based reload

[mkouba]

• currently, a new member value added to an annotation does not trigger
  application restart

[gsmet]

@mkouba not sure it's related but I just had an issue reloading an app that seems to be related to the same area:

2021-01-18 14:06:14,557 ERROR [io.qua.dep.dev.RuntimeUpdatesProcessor] (vert.x-worker-thread-4) Failed to replace classes via instrumentation: java.lang.IllegalStateException: Duplicate key javax.validation.constraints.NotNull (attempted merging values @NotNull and @NotNull)
    at java.base/java.util.stream.Collectors.duplicateKeyException(Collectors.java:133)
    at java.base/java.util.stream.Collectors.lambda$uniqKeysMapAccumulator$1(Collectors.java:180)
    at java.base/java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169)
    at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
    at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
    at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
    at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
    at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
    at io.quarkus.deployment.dev.ClassComparisonUtil.compareAnnotations(ClassComparisonUtil.java:106)
    at io.quarkus.deployment.dev.ClassComparisonUtil.isSameStructure(ClassComparisonUtil.java:73)
    at io.quarkus.deployment.dev.RuntimeUpdatesProcessor.doScan(RuntimeUpdatesProcessor.java:211)
    at io.quarkus.vertx.http.runtime.devmode.VertxHttpHotReplacementSetup$2.handle(VertxHttpHotReplacementSetup.java:62)
    at io.quarkus.vertx.http.runtime.devmode.VertxHttpHotReplacementSetup$2.handle(VertxHttpHotReplacementSetup.java:52)
    at io.vertx.core.impl.ContextImpl.lambda$executeBlocking$2(ContextImpl.java:313)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
    at java.base/java.lang.Thread.run(Thread.java:834)

[gsmet]

I think it happens when you have several times the same annotation on different parameters of the same method as:

        Map<DotName, AnnotationInstance> lookup = b.stream()
                .collect(Collectors.toMap(AnnotationInstance::name, Function.identity()));

is not handling conflicts.

[gsmet]

AFAICS, I can fix it without creating conflicts with what you did so I will push another PR.

[gsmet]

Ah no perfect, you fixed my issue too!

[mkouba]

Unfortunately, it seems that ClassChangeAgent.instrumentation is never set for QuarkusDevModeTest and so I don't know how to write a test for this...