Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add mongodb-rest-data-panache and mongodb-panache-kotlin to native tests #14380

Merged
merged 1 commit into from Jan 19, 2021
Merged

CI: Add mongodb-rest-data-panache and mongodb-panache-kotlin to native tests #14380

merged 1 commit into from Jan 19, 2021

Conversation

famod
Copy link
Member

@famod famod commented Jan 18, 2021

Came up here: https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Why.20is.20OidcClient.20test.20skipped

I noticed that MongoDbRestDataPanacheTest (non-native test) now runs twice, once in the JVM test builds and once in the "Data4" native build.
I did not try to fix it in this PR because it seems quarkus-integration-test-mongodb-rest-data-panache is not the only module with this problem. Or is it even intentional?

@ghost ghost added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Jan 18, 2021
@famod
Copy link
Member Author

famod commented Jan 19, 2021

JDK 15 build failure is unrelated:

2021-01-18T22:46:05.7478039Z [ERROR] Failed to execute goal io.fabric8:docker-maven-plugin:0.31.0:start (docker-start) on project quarkus-integration-test-jpa-db2: I/O Error: Unable to pull 'ibmcom/db2:11.5.4.0' : {"message":"Get https://registry-1.docker.io/v2/ibmcom/db2/manifests/11.5.4.0: EOF"} (Internal Server Error: 500) -> [Help 1]
2021-01-18T22:46:05.7496092Z org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal io.fabric8:docker-maven-plugin:0.31.0:start (docker-start) on project quarkus-integration-test-jpa-db2: I/O Error

@famod
Copy link
Member Author

famod commented Jan 19, 2021

I noticed that MongoDbRestDataPanacheTest (non-native test) now runs twice

Found out why, it is missing this part in the native profile:

                    <plugin>
                        <groupId>org.apache.maven.plugins</groupId>
                        <artifactId>maven-surefire-plugin</artifactId>
                        <configuration>
                            <skipTests>${native.surefire.skip}</skipTests>
                        </configuration>
                    </plugin>

I'll try to clean that up globally in a separte PR.

@famod famod merged commit cd70a1a into quarkusio:master Jan 19, 2021
@ghost ghost added this to the 1.12 - master milestone Jan 19, 2021
@famod famod deleted the ci-add-mongo-native branch January 19, 2021 15:03
@famod
Copy link
Member Author

famod commented Jan 19, 2021

FTR, a global solution for the duplicate test execution is being discussed here: https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Moving.20native.20profile.20to.20IT.20parent.3F

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants