Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ide tooling links to main guides #14505

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Conversation

maxandersen
Copy link
Contributor

Realized we didn't have the IDE work mentioned under main tooling
page. Starting by adding IDE overview from previous blog that we can maintain/expand
as needed.

Over time would be good to have a basic walkthrough per IDE but lets
add that incrementally as it will take some time.

@ghost
Copy link

ghost commented Jan 21, 2021

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@ghost ghost added the area/documentation label Jan 21, 2021
@maxandersen maxandersen changed the title add ide tooling links to main guides Add ide tooling links to main guides Jan 21, 2021
docs/src/main/asciidoc/ide-tooling.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/ide-tooling.adoc Show resolved Hide resolved
|Alpha
|Beta
|Stable (since 2019.3)
|Coming Soon!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:‑/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is from the original ide post made in 2019 - I didn't change these as I don't know what label you put on them today. Are they all just Stable?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We started packaging Che stable releases with a Quarkus devfile since january 2019.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool - but at the time I asked che pm for when and looked at che.openshift.io I was informed it was not available to use/consume. I've changed it to stable now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I think we had resources problems on openshift.io at the time and the Quarkus sample didn't work at all.

docs/src/main/asciidoc/ide-tooling.adoc Outdated Show resolved Hide resolved

|Quarkus Code Snippets
|icon:check[]
|icon:times[]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Quarkus Code Snippets are managed on LS server side all Quarkus toolings which are based on MP / Quarkus LS benefit with MicroProfile / Quarkus Code Snippets:

|Quarkus Code Snippets
|icon:check[]
|icon:check[]
|icon:check[]
|icon:times[]
|icon:check[]

|icon:times[]
|icon:check[]

|Injection Discovery/Navigation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean about this feature? Could you explain more what is this feature please?

Copy link
Contributor Author

@maxandersen maxandersen Feb 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intellij has features similar to what we had/have in jboss tools around find references like feature to navigate from a @Injection and similar annotations to possible sources and other way around.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxandersen for your clarification. Do you think LSP4MP should support this feature?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if feasible - there are quite the special cases to cover and getting UX for it working would be important. in jboss tools very few realized it was even there so almost not used.

|icon:check[]
|icon:times[]

|Config editor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean with Config editor ? (syntax coloration?).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editor that understands Quarkus properties. i.e. provide some quarkus specific content assist, validation, etc.

Copy link

@angelozerr angelozerr Feb 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, Config editor = Config autocompletion + Config validation + ... I though Config editor was a section which provides other things than auto completion, validation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sure - so yeah, so does the tool have any kind of quarkus config editing facility beyond just a text editor with syntax highlighting.

we might actually want to add one for yaml vs properties.

|icon:check[]
|icon:times[]
|icon:check[]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Config definition (navigation from properties file to Java definition) could be good to add too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean seeing where inside quarkus extension the config is defined ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack. added a line for it.

@gsmet
Copy link
Member

gsmet commented Jan 25, 2021

Totally makes sense to have this. Thanks. I'll let you discuss further with Eduardo to finalize it :).

@maxandersen maxandersen marked this pull request as ready for review February 4, 2021 13:01
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a squash.

Other than that, are you folks happy with the changes?

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't IDEs the plural of IDE?

docs/src/main/asciidoc/ide-tooling.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/tooling.adoc Outdated Show resolved Hide resolved
Co-authored-by: Eduardo Ramirez <42619854+ebramirez@users.noreply.github.com>
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@gsmet
Copy link
Member

gsmet commented Feb 19, 2021

I applied the suggestions and squashed.

@gsmet gsmet merged commit ae9c46b into quarkusio:master Feb 19, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Feb 19, 2021
@gsmet gsmet modified the milestones: 1.13 - master, 1.12.1.Final Feb 19, 2021
@gsmet gsmet modified the milestones: 1.12.1.Final, 1.11.4.Final Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants