Reinitialize org.wildfly.common.net.HostName during native application's runtime #14603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plication's runtime
ghost
added
the
gsmet
approved these changes
Jan 26, 2021
dmlloyd
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14423
The commit here re-initializes the
org.wildfly.common.net.HostNameso that this class recomputes various fields that it holds on to as static class level member variables.I decided to add this
@BuildStepin theNativeImageConfigBuildStepsince although the issue happens in JBoss logging (which uses this class), given the nature and usage of thisHostNameclass, it looked more appropriate to not have it tied to logging.Manual testing of the linked issue after this fix worked fine for me locally.