Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Dev-UI logstream changes to allow for better reuse #15024

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Small Dev-UI logstream changes to allow for better reuse #15024

merged 1 commit into from
Feb 12, 2021

Conversation

phillip-kruger
Copy link
Member

This PR is is a new attempt at #15000.
Here we only make the changes to the Dev UI needed to better reuse static content and code in the logging-manager in Quarkiverse.

  • Broke up the 'components' into 3 pieces (navigation, terminal, modals) to better reuse and place them in logging-manager
  • Extract log control functions into separate class, to be reused from the REST Endpoint in Quarkiverse.

Signed-off-by: Phillip Kruger phillip.kruger@gmail.com

… content

Signed-off-by:Phillip Kruger <phillip.kruger@gmail.com>
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phillip-kruger phillip-kruger added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 12, 2021
@gastaldi gastaldi merged commit 9170b6f into quarkusio:master Feb 12, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Feb 12, 2021
@gsmet gsmet modified the milestones: 1.13 - master, 1.12.0.Final Feb 16, 2021
@famod famod removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants