New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Vault Enterprise Namespace #15353
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
@sfauvart this should add the necessary bits. can you take a look and give it a try? I don't have an enterprise vault to test myself. just get my branch and compile it locally with |
Hello @vsevel ! If you want, you can give a try with a local instance of vault-enterprise (in a 'demo' mode for 30 min). It can be used in a quarkus project with the quarkus-smallrye-openapi extension and result simply to change the title of swagger-ui with 'Quarkus API from Vault'. |
@sfauvart Hi, are you OK for Vincent to have ahead with this PR as you have confirmed above it works for you ? thanks |
hi @sberyozkin just to let you know I have been struggling to write proper testing. I will continue these coming days. |
I have been struggling with testing. |
hi @sberyozkin I have found a solution for the tests. one of the changes involved moving the vault url to the config file, rather than returning it from the lifecycle manager. |
Hi Vincent @vsevel, sorry for a delay, I did not quite understand the earlier problem :-), but the test now looks clean and simple, thanks for making it work, so it all LGTM and I'm happy to merge |
Fixes #15349