-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register for reflection the hierarchy of the entity in MongoDB with Panache #15503
Register for reflection the hierarchy of the entity in MongoDB with Panache #15503
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
@geoand can I have your advice on this one ? |
That JPAScavenger thing is pretty old... What is the exact problem you are trying to solve? |
The issue is exaplained in #13301 |
|
24741d5
to
bd5a6c5
Compare
@geoand I added a test, this PR is ready to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #13301
I register for reflection the hierarchy of the entity and not juste the entity itself.
I didn't add any test yet as I wanted to have some feedback on the usage of the
ReflectiveHierarchyBuildItem
as it's the first time I used it. Is my usage correct ?I notice that Hibernate ORM didn't use it and instead use a rather complex way of climbing the hierarchy of types: https://github.com/quarkusio/quarkus/blob/master/extensions/hibernate-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/JpaJandexScavenger.java#L228