Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openshift build error handling #15584

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

iocanel
Copy link
Contributor

@iocanel iocanel commented Mar 9, 2021

Resolves: #13542
Additionally, the pull request does provide as much information as possible when error occurs (correct phase & message from API server).
Last but not least, it will automatically try to re-watch logs, if for any reason the connection is dropped while the build is actually running

@iocanel
Copy link
Contributor Author

iocanel commented Mar 9, 2021

@gsmet @cescoffier I recall discussing about it.

Please note, thatt the re-watch part is something that has not been manually tested, as I can't reproduce locally using crc.

@iocanel iocanel requested a review from geoand March 11, 2021 14:14
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@iocanel iocanel merged commit 258d74e into quarkusio:master Mar 11, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing OpenShift deployment not reporting the error to the Maven build
2 participants