Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid race condition when creating the Dev UI routes #15609

Merged
merged 1 commit into from Mar 10, 2021
Merged

Avoid race condition when creating the Dev UI routes #15609

merged 1 commit into from Mar 10, 2021

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Mar 10, 2021

We need the static resources route to be defined before /dev/* and this
wasn't guaranteed with two concurrent methods.

@gsmet
Avoid race condition when creating the Dev UI routes
dda1c9e 
We need the static resources route to be defined before /dev/* and this
wasn't guaranteed with two concurrent methods.
@gsmet gsmet requested a review from ebullient March 10, 2021 17:32
kenfinnigan
kenfinnigan approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@kenfinnigan kenfinnigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified it fixes the console for me

stuartwdouglas
stuartwdouglas approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@stuartwdouglas stuartwdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The route could also have just been given a higher priority, but this is fine.

@gsmet gsmet merged commit 19e87cc into quarkusio:master Mar 10, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Mar 10, 2021
@gsmet gsmet modified the milestones: 1.13 - master, 1.12.2.Final Mar 10, 2021
This was referenced Mar 12, 2021
Merged
Closed
Merged
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Closed
Closed
Merged
Merged
Closed
This was referenced Mar 12, 2021
Merged
Closed
Merged
Closed
Merged
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Closed
@ebullient ebullient mentioned this pull request Apr 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartwdouglas stuartwdouglas stuartwdouglas approved these changes

@kenfinnigan kenfinnigan kenfinnigan approved these changes

@ebullient ebullient ebullient approved these changes

Assignees
No one assigned
Labels
area/vertx
Projects
None yet
Milestone
1.12.2.Final
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gsmet @stuartwdouglas @kenfinnigan @ebullient