Ensure REST Data Panache updates happens in a single transaction #15640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
gytis
force-pushed
the
rest-data-panache-update-transaction
branch
from
880f481
to
0e874e2
Compare
gytis
changed the title
geoand
reviewed
Mar 12, 2021
...he/runtime/src/main/java/io/quarkus/rest/data/panache/runtime/jta/TransactionalExecutor.java
Outdated
Show resolved
Hide resolved
|
Hm... It seems like now there are a bunch of conflicts because I merged your other PR |
geoand
changed the title
|
Yes that was expected. I had an identical test in another PR that was merged this morning. I'll rebase it. |
gytis
force-pushed
the
rest-data-panache-update-transaction
branch
from
0e874e2
to
269084c
Compare
gytis
force-pushed
the
rest-data-panache-update-transaction
branch
from
269084c
to
7998719
Compare
geoand
approved these changes
Mar 15, 2021
geoand
added
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of weeks ago I've removed the @transactional annotations from the generated JAX-RS resource methods and added them on the RestDataPanache resources that perform data access and modification operations. However, this caused an update endpoint to execute two transactions: one for checking if an entity exists and another to update it. I removed the annotation from the JAX-RS in order to be able to wrap all exceptions (including transaction exceptions) in a custom exception to allow custom error mapping. Therefore, I didn't want to bring it back.
In order to work around this issue I've added a
TransactionalExecutorbean which takes an instance that implements a functional interface and executes it inside a transaction. I thought that this approach is clearer that a bean managed transaction.fixes #15369