Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic documentation on Kubernetes Service Binding #15658

Merged
merged 2 commits into from
Mar 12, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 12, 2021

Also changes the default value of quarkus.kubernetes-service-binding.enabled to true

Resolves: #15626

gsmet
gsmet previously requested changes Mar 12, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a small improvement, otherwise it looks very good!

docs/src/main/asciidoc/deploying-to-kubernetes.adoc Outdated Show resolved Hide resolved
… true

The basic idea is that when the extension is present, an attempt to
find the service bindings makes most sense as the default behavior.
@geoand geoand dismissed gsmet’s stale review March 12, 2021 10:40

comment addressed

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 12, 2021
@geoand geoand merged commit 6d7c3f8 into quarkusio:master Mar 12, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Mar 12, 2021
@geoand geoand deleted the #15626 branch March 12, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing documentation about k8s Service Bindings
3 participants