Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mandrel-flavor in guide #15675

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Fix mandrel-flavor in guide #15675

merged 1 commit into from
Mar 12, 2021

Conversation

gastaldi
Copy link
Contributor

Fixes #15667

@gastaldi gastaldi requested review from zakkak and gsmet March 12, 2021 14:28
@zakkak
Copy link
Contributor

zakkak commented Mar 12, 2021

@gastaldi this makes sense, but I don't know how to test it locally. Could you please give me a pointer to the corresponding documentation or the commands I need to run?

Thanks for the fix!

@gastaldi
Copy link
Contributor Author

@zakkak run mvn clean package -pl docs and open the docs/target/generated-docs/building-native-image.html file in your browser (format won't be the same as the website but it should show you it's correct)

zakkak
zakkak approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gastaldi

@gastaldi gastaldi requested a review from geoand March 12, 2021 15:37
@gastaldi gastaldi merged commit 71189ce into quarkusio:master Mar 12, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Mar 12, 2021
@gastaldi gastaldi deleted the mandrel_fix branch March 12, 2021 15:43
@gastaldi
Copy link
Contributor Author

Thanks!

@geoand
Copy link
Contributor

geoand commented Mar 12, 2021

Thank you!

@zakkak zakkak mentioned this pull request Apr 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakkak zakkak zakkak approved these changes

@geoand geoand geoand approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
1.13.0.CR1
Development

Successfully merging this pull request may close these issues.

mandrel-flavor appearing in https://quarkus.io/guides/building-native-image#container-runtime
4 participants
@gastaldi @zakkak @geoand @gsmet