Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace as many occurrences as possible of master by main #15690

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Mar 12, 2021

This is a consequence of the renaming of the master branch to main but I
also checked all the external URLs to see if they were changed or not. I
updated them if it was the case.

There are still a some problematic occurrences but they are mostly
related to external projects.

@quarkus-bot quarkus-bot bot added area/codestarts area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/kubernetes area/maven area/platform Issues related to definition and interaction with Quarkus Platform area/tika labels Mar 12, 2021
@famod
Copy link
Member

famod commented Mar 12, 2021

Error: Unable to resolve action `DeLaGuardo/setup-graalvm@main`, unable to find version `main`

@gastaldi
Copy link
Contributor

Error: Unable to resolve action `DeLaGuardo/setup-graalvm@main`, unable to find version `main`

When sed substitutions are not so reliable... 😆

@gastaldi
Copy link
Contributor

We should be using a version, really: DeLaGuardo/setup-graalvm@3.1 as suggested in https://github.com/marketplace/actions/setup-graalvm-environment

@famod
Copy link
Member

famod commented Mar 12, 2021

Or just 3 instead of 3.1 to receive updates for the 3.x line. Some other actions are also defined with just the major version. 🤷‍♂️

Edit: Ah, forget about that. The action repo does not provide major version tags...

@gsmet
Copy link
Member Author

gsmet commented Mar 12, 2021

Error: Unable to resolve action DeLaGuardo/setup-graalvm@main, unable to find version main

Obviously I had to miss the one at the end of the file :/

When sed substitutions are not so reliable...

Couldn't use sed. There are a lot of master occurrences that we needed to keep. So I used Eclipse with preview and reviewed each change manually. It was a lot of fun.

We should be using a version, really: DeLaGuardo/setup-graalvm@3.1 as suggested in https://github.com/marketplace/actions/setup-graalvm-environment

As suggested by what? All their examples are using master. Not saying we shouldn't change it but we can do it in another PR.

@gsmet
Copy link
Member Author

gsmet commented Mar 12, 2021

I changed the quarkiverse-docs branch and fixed the branch of the GH Action.

@gastaldi
Copy link
Contributor

As suggested by what?

Click on the big green button and you'll see it 😉

@famod
Copy link
Member

famod commented Mar 12, 2021

Keeping my fingers crossed, but now there is a merge conflict.

@gsmet
Copy link
Member Author

gsmet commented Mar 12, 2021

I'll wait for the full CI run, then fix the conflict and merge.

@famod
Copy link
Member

famod commented Mar 12, 2021

All green! 🎉

This is a consequence of the renaming of the master branch to main but I
also checked all the external URLs to see if they were changed or not. I
updated them if it was the case.

There are still a some problematic occurrences but they are mostly
related to external projects.
@gsmet gsmet merged commit 48e9461 into quarkusio:main Mar 13, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - master milestone Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codestarts area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/kubernetes area/maven area/platform Issues related to definition and interaction with Quarkus Platform area/tika
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants