-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace as many occurrences as possible of master by main #15690
Conversation
|
When |
We should be using a version, really: |
Or just Edit: Ah, forget about that. The action repo does not provide major version tags... |
Obviously I had to miss the one at the end of the file :/
Couldn't use sed. There are a lot of master occurrences that we needed to keep. So I used Eclipse with preview and reviewed each change manually. It was a lot of fun.
As suggested by what? All their examples are using master. Not saying we shouldn't change it but we can do it in another PR. |
I changed the quarkiverse-docs branch and fixed the branch of the GH Action. |
Click on the big green button and you'll see it 😉 |
Keeping my fingers crossed, but now there is a merge conflict. |
I'll wait for the full CI run, then fix the conflict and merge. |
All green! 🎉 |
This is a consequence of the renaming of the master branch to main but I also checked all the external URLs to see if they were changed or not. I updated them if it was the case. There are still a some problematic occurrences but they are mostly related to external projects.
This is a consequence of the renaming of the master branch to main but I
also checked all the external URLs to see if they were changed or not. I
updated them if it was the case.
There are still a some problematic occurrences but they are mostly
related to external projects.