Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added netbeans to the supported IDEs in DEV UI's ability to open in IDE #15724

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Added netbeans to the supported IDEs in DEV UI's ability to open in IDE #15724

merged 1 commit into from
Mar 15, 2021

Conversation

phillip-kruger
Copy link
Member

This PR adds Netbeans to the IDEs that can be opened by Dev UI.

Netbeans runs as a java process, so it's a bit more work to figure out, so this PR include:

  • looking at a combination of process and arguments to figure out if the IDE is running.
  • moved the command to open a file in an IDE to be detected from the arguments (with defaults as it was)

Signed-off-by: Phillip Kruger phillip.kruger@gmail.com

@phillip-kruger
Copy link
Member Author

netbeans

@phillip-kruger
Copy link
Member Author

@geoand - I started looking to support this link in Dev UI log stream, when, with a shock, I figured out Netbeans is not supported. So then I decided to fix that first. :)

After this I'll do the work to make classes clickable in the log.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just added a minor comment (about my comment :))

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 15, 2021
@geoand geoand merged commit 7a2b463 into quarkusio:main Mar 15, 2021
@quarkus-bot quarkus-bot bot added this to the 1.13 - main milestone Mar 15, 2021
@phillip-kruger phillip-kruger deleted the log-to-ide branch March 16, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/vertx triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants