Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent IDE related steps from ever running in remote-dev mode #15764

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Mar 16, 2021

This is needed because otherwise we can get NPEs like

Caused by: java.lang.NullPointerException
	at io.quarkus.deployment.ide.IdeProcessor.lambda$detectIdeFiles$5(IdeProcessor.java:115)

@geoand geoand requested a review from gastaldi March 16, 2021 11:20
This is needed because otherwise we can get NPEs
@gsmet gsmet added this to the 1.13 - main milestone Mar 16, 2021
@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 16, 2021
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsmet gsmet merged commit 6e39ee8 into quarkusio:main Mar 16, 2021
@geoand geoand deleted the remote-dev-ide branch March 16, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants