Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix picocli codestart readme with gradle #15770

Merged
merged 1 commit into from Mar 17, 2021
Merged

Fix picocli codestart readme with gradle #15770

merged 1 commit into from Mar 17, 2021

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Mar 16, 2021 •
edited

Fixes #15758

This PR also rename input codestart data.

@quarkus-bot quarkus-bot bot added area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Mar 16, 2021
@ia3andy ia3andy added this to the 1.13 - main milestone Mar 16, 2021
@ia3andy
Copy link
Contributor Author

ia3andy commented Mar 16, 2021

@gsmet it would be nice to get this one in CR1 because it breaks the codestart api. If it can't make it, it's ok, I will need to change it and don't break the api.

@ia3andy ia3andy requested a review from gastaldi March 16, 2021 13:34
gastaldi
gastaldi approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 16, 2021
@ia3andy
Copy link
Contributor Author

ia3andy commented Mar 16, 2021

Thanks testing and CI 😅, just pushed a fix..

@ia3andy
Copy link
Contributor Author

ia3andy commented Mar 16, 2021

The error doesn't seem to be related, should I rebase?

@gsmet
Copy link
Member

gsmet commented Mar 16, 2021

I don't see any errors? If any and looks unrelated just ping me so I can check. CI is quite overloaded right now so better not push more things if we can avoid it.

@ia3andy
Copy link
Contributor Author

ia3andy commented Mar 16, 2021 •
edited

Really weird, I just had CI with a kubernetes test error on JDK11 Linux & Window, then I hit refresh on the PR and its gone... I must be tired..

@ia3andy
Copy link
Contributor Author

ia3andy commented Mar 16, 2021 •
edited

Ah ok @gsmet mystery solved I was on the previous run which failed for a real reason, but also for the kubernestes reason:
https://github.com/quarkusio/quarkus/runs/2122373145?check_suite_focus=true

@gsmet
Copy link
Member

gsmet commented Mar 16, 2021

Yeah I confirm this is a flaky test, Georgios already disabled it in main. But JDK 8 doesn't run this test so we will have some results anyway.

@ia3andy
Copy link
Contributor Author

ia3andy commented Mar 17, 2021

@gsmet I let you merge that one

@gsmet gsmet merged commit e507d66 into quarkusio:main Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.13.0.CR1
Development

Successfully merging this pull request may close these issues.

Picocli example app readme is incorrect
3 participants
@ia3andy @gsmet @gastaldi