Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to connect to Cloud SQL #15783

Merged
merged 2 commits into from Apr 10, 2021
Merged

Document how to connect to Cloud SQL #15783

merged 2 commits into from Apr 10, 2021

Conversation

loicmathieu
Copy link
Contributor

Fixes #9985

Draft PR due to #15782 that prevent Cloud SQL to work on dev mode.

@loicmathieu
Copy link
Contributor Author

As #15782 didn't seems to be an easy one (no fix possible on our side), maybe I can proceed with this PR and add a link to this issue saying that dev mode didn't work with socket factory at the moment.

I wonder if it works for mysql/sqlserver, didn't test it.

I wonder also if a link to this section could be added to the datasource link and if so in wich section ?

@geoand
Copy link
Contributor

geoand commented Mar 18, 2021

As #15782 didn't seems to be an easy one (no fix possible on our side), maybe I can proceed with this PR and add a link to this issue saying that dev mode didn't work with socket factory at the moment.

Well, that's not entirely true :). We can on our side transform the class in question using an ASM transformer and force the use of the TCCL.
It's not a nice solution, but you are most welcome to try it until we have a proper upstream fix.

@loicmathieu loicmathieu marked this pull request as ready for review March 29, 2021 08:08
@loicmathieu loicmathieu requested a review from geoand March 29, 2021 08:08
@gsmet
Copy link
Member

gsmet commented Apr 8, 2021

Rebased, force-pushed and added a commit with some fixes.

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 8, 2021
@gsmet gsmet merged commit 4afd040 into quarkusio:main Apr 10, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Apr 10, 2021
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
2.0.0.Alpha1
Development

Successfully merging this pull request may close these issues.

Driver does not support socket connection
3 participants
@loicmathieu @geoand @gsmet